Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test #287

Closed
decentral1se opened this issue Mar 20, 2017 · 1 comment
Closed

Fix flaky test #287

decentral1se opened this issue Mar 20, 2017 · 1 comment
Labels
bug
Milestone
P1: MUST

Comments

@decentral1se
Copy link
Contributor

Didn't take much time on this but first seen in https://travis-ci.org/OpenIDC/pyoidc/jobs/213191415.
@decentral1se decentral1se added this to the P1: MUST milestone Mar 20, 2017
This was referenced Mar 22, 2017
Merged
Merged
decentral1se added a commit that referenced this issue Mar 28, 2017
@decentral1se
Mark as failing per #287.
1909376 
This way, we're not getting red builds when we're hacking on
other stuff.
@tpazderka
Copy link
Collaborator

I was digging a little bit into this.

The issue is in sanitize as it will keep B or U before the <REDACTED> if the sensitive part is starting with it.

So it is not an error in test but rather a bug in sanitize function...

sanitize('code=bttt') => code=b<REDACTED>

tpazderka added a commit that referenced this issue Apr 1, 2017
@tpazderka
Fix sanitize to completely replace strings starting with B or U
4443166 
Fix #287
@tpazderka tpazderka mentioned this issue Apr 1, 2017
Merged
tpazderka added a commit that referenced this issue Apr 5, 2017
@tpazderka
Fix sanitize to completely replace strings starting with B or U
d55d30a 
Fix #287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
P1: MUST
Development

No branches or pull requests
2 participants
@decentral1se @tpazderka