Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base URL according to urljoin can only contain one path component. #375

Merged
merged 1 commit into from
Jun 8, 2017
Merged

base URL according to urljoin can only contain one path component. #375

merged 1 commit into from
Jun 8, 2017

Conversation

rohe
Copy link
Contributor

@rohe rohe commented Jun 8, 2017

I have use cases where that is not true.

@coveralls
Copy link

coveralls commented Jun 8, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 62.94% when pulling 75fe84d on rohe:fix_urljoin into 7dd51a5 on OpenIDC:master.

@schlenk
Copy link
Collaborator

schlenk commented Jun 8, 2017

LGTM.

And yes, guess there are some other instances where urljoin() isn't the right tool for the job. Probably always when baseurl contains a path.

@rohe rohe merged commit bf321f1 into CZ-NIC:master Jun 8, 2017
@decentral1se
Copy link
Contributor

I have use cases where that is not true.

Test case would be preferred 😄

@rohe rohe deleted the fix_urljoin branch June 9, 2017 09:00
@tpazderka tpazderka mentioned this pull request Aug 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rohe @coveralls @schlenk @decentral1se