Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not append cookie_header if there is nothing to append #593

Merged
merged 1 commit into from
Jan 20, 2019
Merged

Do not append cookie_header if there is nothing to append #593

merged 1 commit into from
Jan 20, 2019

Conversation

tpazderka
Copy link
Collaborator

Close #592

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.

@codecov-io

This comment has been minimized.

Sign in to view
@codecov-io

This comment has been minimized.

Sign in to view
schlenk
schlenk approved these changes Jan 19, 2019
View reviewed changes
Copy link
Collaborator

@schlenk schlenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The other_cookie_exists test is a little strange, as it tests that bug #398 still exists. But it tests the current code.

@tpazderka tpazderka merged commit 3f6c834 into master Jan 20, 2019
@tpazderka tpazderka deleted the fix-cookie-headers branch January 20, 2019 22:53
@tpazderka tpazderka mentioned this pull request Jan 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlenk schlenk schlenk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tpazderka @codecov-io @schlenk