Remove fakeserver #682
Merged
Remove fakeserver #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
schlenk
reviewed
Aug 16, 2019
| @@ -839,6 +839,7 @@ def do_access_token_request( | |||
| http_args = ht_args | |||
| else: | |||
| http_args.update(ht_args) | |||
| http_args.pop("password", None) | |||
There was a problem hiding this comment.
For some reason it was passing through and ended up as an invalid kwarg to requests library...
There was a problem hiding this comment.
ok. It is wrong in any case, so the fix should do no harm, but probably the issue is burried somewhere in request_info().
There was a problem hiding this comment.
Yes, my guess as well. But didn't want to spend a huge amount of time on that. Will make a separate issue for that...
schlenk
approved these changes
Aug 16, 2019
| @@ -839,6 +839,7 @@ def do_access_token_request( | |||
| http_args = ht_args | |||
| else: | |||
| http_args.update(ht_args) | |||
| http_args.pop("password", None) | |||
There was a problem hiding this comment.
ok. It is wrong in any case, so the fix should do no harm, but probably the issue is burried somewhere in request_info().
tpazderka
force-pushed
the
remove_fakeserver
branch
from
957bb4b to
db09008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md.Replace it by testing with responses.
It tends to break on changes to provider and is just basically a separate implementation.