Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOI Badge Is Broken #743

Closed
jmwright opened this issue Apr 24, 2021 · 9 comments · Fixed by #748
Closed

DOI Badge Is Broken #743

jmwright opened this issue Apr 24, 2021 · 9 comments · Fixed by #748
Labels

Comments

@jmwright
Copy link
Member

I noticed that the DOI badge in the readme was just displaying text instead of an image, and looked into it. It looks like the links for the badge SVG and the URL the badge points to have changed.

Old DOI Badge Markdown:

[![DOI](https://zenodo.org/badge/155099400.svg)](https://zenodo.org/badge/latestdoi/155099400)

New DOI Badge Markdown:

[![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.4498634.svg)](https://doi.org/10.5281/zenodo.4498634)

I clicked on the DOI badge in the right sidebar here to get the new information. I can change it, but wasn't involved in adding the DOI badge and I wanted to make sure I wasn't missing something.

@fedorkotov
Copy link
Contributor

Is it really fixed? This is what I see (Firefox 88.0 64-bit, Windows 8.1)
image

@jmwright
Copy link
Member Author

@fedorkotov I wasn't paying attention and didn't get that change committed with the other PR. I've fixed it and CI is running on the merge right now. If it's not fixed after CI has finished, I'll edit directly on GitHub so that I can use the preview.

@jmwright jmwright reopened this Apr 28, 2021
@jmwright
Copy link
Member Author

So the link is updated in the badge now, but it seems we're not alone in having the badge refuse to display.

zenodo/zenodo#2165

There are a couple of odd things in their generated SVG file. I may experiment with that a little bit.

@fedorkotov
Copy link
Contributor

There are a couple of odd things in their generated SVG file

It takes 26 seconds to load from where I am (Moscow, Russia).
After it is finally loaded it looks ok
image

<svg xmlns="http://www.w3.org/2000/svg"
     width="186" height="20">
        <linearGradient id="b" x2="0" y2="100%">
            <stop offset="0" stop-color="#bbb" stop-opacity=".1"/>
            <stop offset="1" stop-opacity=".1"/>
        </linearGradient>
        <mask id="a" width="186" height="20">
            <rect width="186" height="20" rx="3"
            fill="#fff"/>
        </mask>
        <g mask="url(#a)">
            <path fill="#555" d="M0 0h31v20H0z" />
            <path fill="#007ec6"
            d="M31 0h155v20H31z"
            />
            <path fill="url(#b)" d="M0 0h186v20H0z" />
        </g>
        <g fill="#fff" text-anchor="middle" font-family="DejaVu Sans,
        Verdana,Geneva,sans-serif" font-size="11">
            <text x="16" y="15" fill="#010101"
            fill-opacity=".3">
                DOI
            </text>
            <text x="16" y="14">
                DOI
            </text>
            <text x="108"
            y="15" fill="#010101" fill-opacity=".3">
                10.5281/zenodo.4498634
            </text>
            <text x="108" y="14">
                10.5281/zenodo.4498634
            </text>
        </g>
    </svg>

@jmwright
Copy link
Member Author

It's taking about that long for the image to load for me in the US too. Maybe GitHub is timing out while trying to load the image?

I tried uploading the SVG to my own web server and it loads fine in the readme. I guess I'll change the readme to point to the temporary image location and leave this issue open so we can circle back when Zenodo has their issue fixed.

jmwright added a commit that referenced this issue Apr 28, 2021
@jmwright
Copy link
Member Author

Ok, change made and badge is visible again. Thanks for the feedback on this issue @fedorkotov

@jmwright
Copy link
Member Author

Looks like there might be a content header issue on Zenodo's side in addition to the long load times.

zenodo/zenodo#2165 (comment)

@jmwright
Copy link
Member Author

jmwright commented May 4, 2021

This appears to be fixed now on Zenodo's side, although there has been no communication on what happened. The issue was closed and the badge SVG now works.

@jmwright jmwright closed this as completed May 4, 2021
@adam-urbanczyk
Copy link
Member

Thanks for looking into this @jmwright !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants