Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nptyping dependency #1047

Closed
wants to merge 1 commit into from
Closed

Conversation

njourdane
Copy link

@njourdane njourdane commented Apr 8, 2022

Use nptyping<2 as dependency, because the new nptyping 2.0 release introduced a bug (nptyping.error.InvalidArgumentsError).

Fix #1046.

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #1047 (81b0b13) into master (d4b5eec) will not change coverage.
The diff coverage is n/a.

❗ Current head 81b0b13 differs from pull request most recent head d5b238d. Consider uploading reports for the commit d5b238d to get more accurate results

@@           Coverage Diff           @@
##           master    #1047   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files          40       40           
  Lines        9405     9405           
  Branches     1248     1248           
=======================================
  Hits         9059     9059           
  Misses        204      204           
  Partials      142      142           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@jmwright
Copy link
Member

@roipoussiere Thanks. This may end up being superceded by #1050 but it will stay open until after the review process is complete.

@adam-urbanczyk
Copy link
Member

Thanks @roipoussiere , solved in #1050

@njourdane njourdane deleted the fix-nptyping-dep branch April 12, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when importing cadquery: nptyping.error.InvalidArgumentsError
3 participants