-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the ability for the user to adjust the tolerance and angular tolerance of VRML tessellation #1066
Conversation
…lerance of VRML tessellation
Codecov Report
@@ Coverage Diff @@
## master #1066 +/- ##
=======================================
Coverage 96.32% 96.32%
=======================================
Files 40 40
Lines 9407 9407
Branches 1248 1248
=======================================
Hits 9061 9061
Misses 204 204
Partials 142 142
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
I think this is ready for review now. @adam-urbanczyk and @lorenzncode I requested reviews from you two, but if either of you don't have time to review let me know and I'll request from someone else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's expose tolerance and angular tolerance to Assembly.save
as well.
Line 445 in 2eeabc8
exportVRML(self, path) |
exportVRML(self, path, tolerance, angularTolerance)
@lorenzncode Fixed CI, so I cna merge this now. Thanks for the reviews. |
With the KiCAD 3D model generator the generated VRML files were 6MB, which was too large compared to the ~200KB original files. I added the ability for the user to adjust the
tolerance
andangularTolerance
so that I could decrease the file size. I don't think I'll be able to keep the same quality at ~200MB, but I can get vast improvements in file size with these changes.