Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VTK based assembly export rotation issue #1078

Merged
merged 1 commit into from
May 4, 2022

Conversation

lorenzncode
Copy link
Member

To resolve #1069. As a test, I'm checking a line of the VRML file itself. The file is less than 50 lines.

#VRML V2.0 utf8
# VRML file written by the visualization toolkit

    Background {
    skyColor [1.000000 1.000000 1.000000, ]
    }
     Viewpoint
      {
      fieldOfView 0.523599
      position -1.000000 0.000000 1.931852
      description "Default View"
      orientation 0 0 1 0
      }
    NavigationInfo {
      type ["EXAMINE","FLY"]
      speed 4.000000
      headlight TRUE}

    DirectionalLight { ambientIntensity 1 intensity 0 # ambient light
      color 1.000000 1.000000 1.000000 }

    Transform {
      translation 0 0 0
      rotation 1 0 0 1.5707963267948966
      scale 1 1 1
      children [
        Shape {
          appearance Appearance {
            material Material {
              ambientIntensity 0
              emissiveColor 0 0 0
              diffuseColor 1 1 1
              specularColor 0 0 0
              shininess 0.0078125
              transparency 0
              }
            }
          geometry PointSet {
            coord Coordinate {              point [                            -1 0 0,
              ]
            }
          }
        }
      ]
    }

rotation 1 0 0 1.5707963267948966

This is X rotation, 90 degrees.

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.32%. Comparing base (c57b849) to head (ba73f36).
Report is 328 commits behind head on master.

Files Patch % Lines
tests/test_exporters.py 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1078   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files          40       40           
  Lines        9407     9427   +20     
  Branches     1248     1251    +3     
=======================================
+ Hits         9061     9081   +20     
  Misses        204      204           
  Partials      142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @lorenzncode

@jmwright jmwright requested a review from adam-urbanczyk May 4, 2022 15:20
@adam-urbanczyk
Copy link
Member

LGTM, merging. Thanks @lorenzncode

@adam-urbanczyk adam-urbanczyk merged commit fddf510 into CadQuery:master May 4, 2022
@lorenzncode lorenzncode deleted the assy-export-rotation branch May 4, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assemble VRML export incorrect rotation
3 participants