Add parameter and return types to importDXF #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sethfischer
commented
Dec 16, 2022
sethfischer
commented
- add parameter and return types
- fix param filename case in docstring
- fix disjointed paragraph in rendered docs
- format example code with black
* add parameter and return types * fix param filename case in docstring * fix disjointed paragraph in rendered docs * format example code with black
Codecov Report
@@ Coverage Diff @@
## master #1205 +/- ##
=======================================
Coverage 94.01% 94.01%
=======================================
Files 26 26
Lines 5413 5414 +1
Branches 919 919
=======================================
+ Hits 5089 5090 +1
Misses 193 193
Partials 131 131
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jmwright
approved these changes
Dec 16, 2022
adam-urbanczyk
approved these changes
Dec 16, 2022
|
LGTM, thanks @sethfischer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.