-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update assembly constraint docs #1210
Conversation
lorenzncode
commented
Dec 23, 2022
- Correct FixedPoint constraint example
- Simplify Location usage in examples and format with black for consistency
* Correct FixedPoint constraint example * Simplify Location usage in examples and format with black for consistency
Codecov Report
@@ Coverage Diff @@
## master #1210 +/- ##
==========================================
+ Coverage 94.01% 94.07% +0.05%
==========================================
Files 26 26
Lines 5414 5414
Branches 919 919
==========================================
+ Hits 5090 5093 +3
+ Misses 193 190 -3
Partials 131 131
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Fixes #1159. I removed a note on STEP and transparency. I find that STEP export includes transparency data so the note may be out of date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lorenzncode !
@jmwright Thanks for confirming transparency is working for you! Regarding colors, PR #1157 attempts to resolve an issue with STEP export and color handling. I've tested STEP export with the PR branch and several viewers, including FreeCAD and Autodesk, and did not find any problem. You might try exporting the STEP again with the PR 1157 branch to see if it resolves the color issue when viewing in FreeCAD. |
@lorenzncode I just tested in FreeCAD 0.20.1 and the color and alpha worked, but I had to turn off the STEP import option |