-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix incorrect coordinate system of glTF exports #1211
Conversation
|
Codecov Report
@@ Coverage Diff @@
## master #1211 +/- ##
==========================================
+ Coverage 94.01% 94.07% +0.06%
==========================================
Files 26 26
Lines 5414 5421 +7
Branches 919 919
==========================================
+ Hits 5090 5100 +10
+ Misses 193 190 -3
Partials 131 131
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @uki-dev !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the change - importing to Blender, CAD Assistant, Mayo, and PlayCanvas.
All displayed the model in the desired orientation by default except for Mayo. For Mayo, the GLTF Import option "System Coordinates Converter" can be changed from the default of "Undefined".
correctly exports glTF in right-handed +Y up coordinate space as defined in the glTF specification
before:
after: