Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect coordinate system of glTF exports #1211

Merged
merged 4 commits into from
Dec 26, 2022

Conversation

uki-dev
Copy link
Contributor

@uki-dev uki-dev commented Dec 23, 2022

correctly exports glTF in right-handed +Y up coordinate space as defined in the glTF specification

before:
before

after:
after

@uki-dev
Copy link
Contributor Author

uki-dev commented Dec 24, 2022

AssemblyProtocol.loc is seemingly read-only , are there any other recommendations on how i could address this ?

@codecov
Copy link

codecov bot commented Dec 25, 2022

Codecov Report

Merging #1211 (f27883d) into master (e23f43d) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1211      +/-   ##
==========================================
+ Coverage   94.01%   94.07%   +0.06%     
==========================================
  Files          26       26              
  Lines        5414     5421       +7     
  Branches      919      919              
==========================================
+ Hits         5090     5100      +10     
+ Misses        193      190       -3     
  Partials      131      131              
Impacted Files Coverage Δ
cadquery/occ_impl/assembly.py 98.44% <100.00%> (+0.02%) ⬆️
cadquery/occ_impl/exporters/assembly.py 100.00% <100.00%> (ø)
cadquery/cqgi.py 80.73% <0.00%> (+1.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @uki-dev !

Copy link
Member

@lorenzncode lorenzncode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the change - importing to Blender, CAD Assistant, Mayo, and PlayCanvas.

All displayed the model in the desired orientation by default except for Mayo. For Mayo, the GLTF Import option "System Coordinates Converter" can be changed from the default of "Undefined".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants