-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of cq.Shape selectors #1406
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1406 +/- ##
==========================================
+ Coverage 94.19% 94.23% +0.03%
==========================================
Files 27 28 +1
Lines 5740 5779 +39
Branches 983 984 +1
==========================================
+ Hits 5407 5446 +39
Misses 199 199
Partials 134 134
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@adam-urbanczyk This PR is still marked as draft. Is this an interim review, or a final review? All the tests are in place and pass, so I wondered if maybe the intent was to take the PR out of draft. |
I forgot to undraft it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things seem to work well as far as I can tell. Thanks @adam-urbanczyk !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some testing with the PR branch and did not find any issue. Thanks @adam-urbanczyk !
Refactor - move more stuff to shape (?)