-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multisection sweep for sketches #1408
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1408 +/- ##
=======================================
Coverage 94.19% 94.20%
=======================================
Files 27 27
Lines 5740 5745 +5
Branches 983 986 +3
=======================================
+ Hits 5407 5412 +5
Misses 199 199
Partials 134 134
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Since the inner wires are ignored in multisection sweep, this may be another use case for a shell thicken method (#1269) as in:
result = (
cq.Workplane()
.placeSketch(sketch1.moved(p.locationAt(0)), sketch2.moved(p.locationAt(1)))
.sweep(p, multisection=True, makeSolid=False)
.val()
.thicken(2)
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adam-urbanczyk !
Fixes #1407, #1397