Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multisection sweep for sketches #1408

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Conversation

adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Sep 28, 2023

Fixes #1407, #1397

@adam-urbanczyk adam-urbanczyk linked an issue Sep 28, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #1408 (ec312a9) into master (d780127) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head ec312a9 differs from pull request most recent head 24fe97f. Consider uploading reports for the commit 24fe97f to get more accurate results

@@           Coverage Diff           @@
##           master    #1408   +/-   ##
=======================================
  Coverage   94.19%   94.20%           
=======================================
  Files          27       27           
  Lines        5740     5745    +5     
  Branches      983      986    +3     
=======================================
+ Hits         5407     5412    +5     
  Misses        199      199           
  Partials      134      134           
Files Coverage Δ
cadquery/cq.py 92.34% <100.00%> (+0.01%) ⬆️
cadquery/occ_impl/shapes.py 93.09% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adam-urbanczyk adam-urbanczyk linked an issue Sep 29, 2023 that may be closed by this pull request
Copy link
Member

@lorenzncode lorenzncode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Since the inner wires are ignored in multisection sweep, this may be another use case for a shell thicken method (#1269) as in:

result = (
    cq.Workplane()
    .placeSketch(sketch1.moved(p.locationAt(0)), sketch2.moved(p.locationAt(1)))
    .sweep(p, multisection=True, makeSolid=False)
    .val()
    .thicken(2)
)

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adam-urbanczyk !

@jmwright jmwright merged commit 8c2865c into master Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multisection Sweep with Sketches Support configuring console output verbosity
3 participants