Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require at least 3.8 #1468

Merged
merged 2 commits into from
Dec 24, 2023
Merged

Require at least 3.8 #1468

merged 2 commits into from
Dec 24, 2023

Conversation

adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Dec 20, 2023

Related to #1440

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (245b6f3) 94.41% compared to head (ea4b0d2) 94.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1468      +/-   ##
==========================================
- Coverage   94.41%   94.41%   -0.01%     
==========================================
  Files          28       28              
  Lines        5769     5765       -4     
  Branches     1068     1068              
==========================================
- Hits         5447     5443       -4     
  Misses        194      194              
  Partials      128      128              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmwright
Copy link
Member

@adam-urbanczyk Should the line be something like python>=3.8,<=3.12 to prevent breakage when Python 3.13/3.14 is released?

@adam-urbanczyk
Copy link
Member Author

Trivial change, going ahead with the merge.

@adam-urbanczyk adam-urbanczyk merged commit 5de4d9f into master Dec 24, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants