Fix VTK assembly render apply gp_Intrinsic_ZXY rotation #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1540 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 28 28
Lines 5780 5783 +3
Branches 1071 1071
=======================================
+ Hits 5461 5464 +3
Misses 193 193
Partials 126 126 ☔ View full report in Codecov by Sentry. |
jmwright
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1538
See also
SetOrientationhttps://vtk.org/doc/nightly/html/classvtkProp3D.htmlLocationmight instead be enhanced to provide optional parameter to setgp_EulerSequencesay intoTuple. Currently hardcoding in the VTK function.