-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 2D and 3D Wire fillet #1549
Conversation
d817b23
to
0f67bd5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1549 +/- ##
==========================================
+ Coverage 94.50% 94.54% +0.03%
==========================================
Files 28 28
Lines 5804 5846 +42
Branches 1076 1165 +89
==========================================
+ Hits 5485 5527 +42
Misses 193 193
Partials 126 126 ☔ View full report in Codecov by Sentry. |
Hey, thanks, but could you not force push |
@adam-urbanczyk Regarding the PR itself, I added a vertices parameter, but in terms of a list of vertex indices. I was wondering whether it might be better to give the coordinates. What do you think? |
Every push will trigger CI, am I missing something? |
More work will be needed on this. I'll try to add |
🥳 |
FYI: in the end I refactored |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dov there is just the one comment suggestion from me.
Thanks @dov ! |
Add support for 2D and 3D Wire fillet through OCCT ChFi2d_FilletAPI