Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 2D and 3D Wire fillet #1549

Merged
merged 12 commits into from
Apr 6, 2024
Merged

Conversation

dov
Copy link
Contributor

@dov dov commented Mar 24, 2024

Add support for 2D and 3D Wire fillet through OCCT ChFi2d_FilletAPI

@dov dov force-pushed the wire-fillet branch 3 times, most recently from d817b23 to 0f67bd5 Compare March 24, 2024 20:10
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (76fbff7) to head (d20379a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1549      +/-   ##
==========================================
+ Coverage   94.50%   94.54%   +0.03%     
==========================================
  Files          28       28              
  Lines        5804     5846      +42     
  Branches     1076     1165      +89     
==========================================
+ Hits         5485     5527      +42     
  Misses        193      193              
  Partials      126      126              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-urbanczyk
Copy link
Member

Hey, thanks, but could you not force push

@dov
Copy link
Contributor Author

dov commented Mar 25, 2024

@adam-urbanczyk
Regarding force push. Sorry, I was (ab-)using it in order to get the CI support. I'll make sure in the future to clean all the CI errors before creating pull requests.

Regarding the PR itself, I added a vertices parameter, but in terms of a list of vertex indices. I was wondering whether it might be better to give the coordinates. What do you think?

@adam-urbanczyk
Copy link
Member

Every push will trigger CI, am I missing something?

@adam-urbanczyk
Copy link
Member

More work will be needed on this. I'll try to add startVertex() and endVertex() methods.

@adam-urbanczyk adam-urbanczyk requested a review from jmwright April 2, 2024 16:40
@dov
Copy link
Contributor Author

dov commented Apr 2, 2024

🥳

@adam-urbanczyk
Copy link
Member

FYI: in the end I refactored Wire.Vertices() so that the rv is ordered.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dov there is just the one comment suggestion from me.

@dov
Copy link
Contributor Author

dov commented Apr 6, 2024

Thanks @dov there is just the one comment suggestion from me.

Thanks @jmwright . I fixed it and also removed another typo in the comment.

@adam-urbanczyk adam-urbanczyk merged commit 3451007 into CadQuery:master Apr 6, 2024
5 checks passed
@adam-urbanczyk
Copy link
Member

Thanks @dov !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants