Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read global element variable at creation time of the promise,… #1566

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

kalanzun
Copy link
Contributor

…not during resolve.

At resolve time, the global variable might already have changed.

Fix #1565

…ing resolve.

At resolve time, the global variable might already have changed.
@kalanzun
Copy link
Contributor Author

I did not add a test. To actually test it, we would need to add jupyter lab and playwright to the dev environment. That might not be worth it?

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (99792e5) to head (44438d6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1566   +/-   ##
=======================================
  Coverage   94.54%   94.54%           
=======================================
  Files          28       28           
  Lines        5848     5848           
  Branches     1166     1166           
=======================================
  Hits         5529     5529           
  Misses        193      193           
  Partials      126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmwright
Copy link
Member

Looks good. Thanks @kalanzun and @adam-urbanczyk

@jmwright jmwright merged commit 5522037 into CadQuery:master Apr 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In jupyter lab html export, all cadquery object displays pile up with the last one
3 participants