-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for closed path fillet to Wire.fillet() #1573
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1573 +/- ##
=======================================
Coverage 94.86% 94.86%
=======================================
Files 28 28
Lines 6226 6231 +5
Branches 1261 1264 +3
=======================================
+ Hits 5906 5911 +5
Misses 193 193
Partials 127 127 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@jmwright will you take a look? I had to replace some uses of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to merge
Thanks @dov ! |
This PR adds support for fillet of a closed wire to the
Wire.fillet()
method, by adding a fillet arc between the last and the first segments