-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shape and workplane support to the Workplane.eachpoint() function. Issue #1395 #1578
Conversation
0dd6765
to
ddb6a3d
Compare
@dov could you run black? |
@adam-urbanczyk Ok. I just did. It isn't trivial since the rest of the files are not compliant. (However, I just found "darken", which makes it easy). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1578 +/- ##
=======================================
Coverage 94.85% 94.86%
=======================================
Files 28 28
Lines 6216 6226 +10
Branches 1251 1261 +10
=======================================
+ Hits 5896 5906 +10
Misses 193 193
Partials 127 127 ☔ View full report in Codecov by Sentry. |
@dov The following command should show just what is needed to fix your changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dov I just had a couple of corrections to a comment. Otherwise it looks good.
Co-authored-by: Jeremy Wright <[email protected]>
Thanks @dov |
This PR solves issue #1395 and adds the ability to use the
Workplane.eachpoint()
function with aShape
and aWorkplane
.Here are is an example for using a wire to do a
cutThru()
:And here is an example for using another workplane, adding a sphere to the center of each face: