-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cq.Shape and some free-func improvements #1672
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1672 +/- ##
==========================================
+ Coverage 95.15% 95.23% +0.07%
==========================================
Files 27 27
Lines 6485 6521 +36
Branches 1346 1352 +6
==========================================
+ Hits 6171 6210 +39
+ Misses 191 187 -4
- Partials 123 124 +1 ☔ View full report in Codecov by Sentry. |
thank you @adam-urbanczyk , this would be enabling :) |
Excellent! This would help with our work @adam-urbanczyk |
@adam-urbanczyk Thanks for this PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, no other issues found in limited testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @adam-urbanczyk !
Alright, merging. |
paramAt
for position [consistency]isSolid
fix [bugfix]solid
improvements [free-func]check
[free-func]innerShells
[consistency]outerShell
[consistency]