Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cq.Shape and some free-func improvements #1672

Merged
merged 16 commits into from
Oct 8, 2024
Merged

Conversation

adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Sep 25, 2024

  • paramAt for position [consistency]
  • isSolid fix [bugfix]
  • solid improvements [free-func]
  • check [free-func]
  • innerShells [consistency]
  • outerShell [consistency]
  • tests

@adam-urbanczyk adam-urbanczyk marked this pull request as draft September 25, 2024 17:54
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.23%. Comparing base (5429f61) to head (de5cc76).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1672      +/-   ##
==========================================
+ Coverage   95.15%   95.23%   +0.07%     
==========================================
  Files          27       27              
  Lines        6485     6521      +36     
  Branches     1346     1352       +6     
==========================================
+ Hits         6171     6210      +39     
+ Misses        191      187       -4     
- Partials      123      124       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-urbanczyk adam-urbanczyk changed the title Shape improvements cq.Shape and some free-func improvements Oct 1, 2024
@adam-urbanczyk adam-urbanczyk marked this pull request as ready for review October 1, 2024 16:12
@eguiraud-pf
Copy link

thank you @adam-urbanczyk , this would be enabling :)

@rherrero-pf
Copy link

Excellent! This would help with our work @adam-urbanczyk

@jons-pf
Copy link

jons-pf commented Oct 7, 2024

@adam-urbanczyk Thanks for this PR!

Copy link
Member

@lorenzncode lorenzncode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, no other issues found in limited testing.

cadquery/occ_impl/shapes.py Show resolved Hide resolved
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @adam-urbanczyk !

@adam-urbanczyk
Copy link
Member Author

Alright, merging.

@adam-urbanczyk adam-urbanczyk merged commit 5720c7d into master Oct 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cq.Solid.isSolid() not working? Implement outerShell
6 participants