-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More shape/free func improvements #1692
Conversation
…uery into shape-improvements
A lot of small, mostly advanced, but very useful stuff. |
Is this pts = [
(0, 0),
(1, 0),
(0, 1),
]
f1 = face(polygon(*pts))
f2 = f1.trim(0, 0.5, 0, 1)
print(f2.Area()) # this returns 0.5; I was expecting 0.375 which is the area of f1 * f2 here? |
cadquery/occ_impl/shapes.py
Outdated
builder.Init(True, ruled) | ||
builder = _make_builder(True) | ||
|
||
# used to check is building inner parts makes sense |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# used to check is building inner parts makes sense | |
# used to check if building inner parts makes sense |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adam-urbanczyk !
@lorenzncode I think everything is fixed, anything against merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adam-urbanczyk! Yes please go ahead. Do you want to link the font issue with this PR? #1639 can be closed with this too.
cq.vis.show
demo: