Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text fixes and some shape/free func additions #1700

Merged
merged 85 commits into from
Nov 24, 2024
Merged

Conversation

adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Nov 13, 2024

  • single letter fix
  • 2D text on path
  • text on path
  • text on path/face
  • bin brep import/export
  • solid constructors tweaks
  • symmetric offset
  • "infinite" plane
  • triangulation edge visualization

fixes #108, #109, #1581

afbeelding
afbeelding

@adam-urbanczyk adam-urbanczyk linked an issue Nov 17, 2024 that may be closed by this pull request
@adam-urbanczyk adam-urbanczyk marked this pull request as ready for review November 20, 2024 07:34
@adam-urbanczyk adam-urbanczyk changed the title Text fixes Text fixes and some shape/free func additions Nov 20, 2024
cadquery/vis.py Outdated Show resolved Hide resolved
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adam-urbanczyk !

@lorenzncode
Copy link
Member

Not critical, but I noticed an issue with the git log with duplicated messages. It seems that since the same branch is used for the last few PR, the messages are repeated.

For example compare the first ~30 lines of the message of these two commits:

$ git log --pretty=format:'%h %ad%n%s%n%b' -n 1 a175c | head -n 30 | grep -E "\S"
a175cb8 Mon Nov 11 23:21:49 2024 +0100
More shape/free func improvements (#1692)
* Initial commit of better paramAt, solid and a new function check
* mypy fix
* isSolid fix
* Implement outerShell, innerShells
* Imports cleanup
* Typo fix
* Make paramAt fully compatibile with Wires
* Typo fix
* Add check test
* Fix orientation handling
* Add test
* paramAt test
* More tests
* Add orientation fix and optimize check

$ git log --pretty=format:'%h %ad%n%s%n%b' -n 1 5720c | head -n 30 | grep -E "\S"
5720c7d Tue Oct 8 18:08:58 2024 +0200
cq.Shape and some free-func improvements (#1672)
* Initial commit of better paramAt, solid and a new function check
* mypy fix
* isSolid fix
* Implement outerShell, innerShells
* Imports cleanup
* Typo fix
* Make paramAt fully compatibile with Wires
* Typo fix
* Add check test
* Fix orientation handling
* Add test
* paramAt test
* More tests
* Add orientation fix and optimize check

Maybe the commit message can be manually edited when this is checked-in.

Looks interesting, I'll do some testing of the changes.

@lorenzncode
Copy link
Member

lorenzncode commented Nov 23, 2024

Is it possible to create a solid from a mix of shells and faces?

w1 = rect(10, 10)
sh1 = extrude(w1, (0, 0, 5))  # box sides (shell)

f1 = plane(10, 10)  # bottom face
f2 = plane(10, 10).move((0, 0, 5)) # top face

# create solid box from shell and faces?
# box1 = solid(...)

edit: more straightforward way to create the face

@adam-urbanczyk
Copy link
Member Author

ATM like so solid(f1, f2, *sh1)

Copy link
Member

@lorenzncode lorenzncode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new features! Thanks @adam-urbanczyk !

doc/free-func.rst Outdated Show resolved Hide resolved
doc/free-func.rst Outdated Show resolved Hide resolved
@adam-urbanczyk adam-urbanczyk merged commit 2629bf9 into master Nov 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cq.Shape free func OCC feature Requires coding at OCC implementation level text rendering Features and issues related to text rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text placement on a 2D curve
3 participants