-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text fixes and some shape/free func additions #1700
Conversation
…uery into shape-improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adam-urbanczyk !
Not critical, but I noticed an issue with the git log with duplicated messages. It seems that since the same branch is used for the last few PR, the messages are repeated. For example compare the first ~30 lines of the message of these two commits:
Maybe the commit message can be manually edited when this is checked-in. Looks interesting, I'll do some testing of the changes. |
Co-authored-by: Jeremy Wright <[email protected]>
Is it possible to create a solid from a mix of shells and faces? w1 = rect(10, 10)
sh1 = extrude(w1, (0, 0, 5)) # box sides (shell)
f1 = plane(10, 10) # bottom face
f2 = plane(10, 10).move((0, 0, 5)) # top face
# create solid box from shell and faces?
# box1 = solid(...) edit: more straightforward way to create the face |
ATM like so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new features! Thanks @adam-urbanczyk !
fixes #108, #109, #1581