Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final shape / free func tweaks #1731

Merged
merged 17 commits into from
Dec 26, 2024
Merged

Final shape / free func tweaks #1731

merged 17 commits into from
Dec 26, 2024

Conversation

adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Dec 18, 2024

  • sample
  • isoline
  • detailed check output
  • expose API in func: from cadquery.func import *
  • tests

afbeelding
afbeelding

@adam-urbanczyk adam-urbanczyk marked this pull request as draft December 18, 2024 20:44
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 96.49123% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.31%. Comparing base (6b3b14a) to head (86e11d8).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
cadquery/occ_impl/shapes.py 96.15% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1731      +/-   ##
==========================================
- Coverage   95.32%   95.31%   -0.02%     
==========================================
  Files          27       28       +1     
  Lines        6788     6888     +100     
  Branches     1013     1044      +31     
==========================================
+ Hits         6471     6565      +94     
- Misses        193      195       +2     
- Partials      124      128       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-urbanczyk adam-urbanczyk mentioned this pull request Dec 23, 2024
6 tasks
@adam-urbanczyk adam-urbanczyk marked this pull request as ready for review December 23, 2024 17:19
tests/test_shapes.py Outdated Show resolved Hide resolved
Copy link
Member

@lorenzncode lorenzncode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new free func import method!

cadquery/occ_impl/shapes.py Outdated Show resolved Hide resolved
cadquery/occ_impl/shapes.py Outdated Show resolved Hide resolved
Sample a curve based on a number of points or deflection.

:param n: number of positions or deflection
:return: A list of Vectors and a list of parameters.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this supposed to be "returns" in this context?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adam-urbanczyk !

@adam-urbanczyk adam-urbanczyk merged commit 1c0e747 into master Dec 26, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants