-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final shape / free func tweaks #1731
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1731 +/- ##
==========================================
- Coverage 95.32% 95.31% -0.02%
==========================================
Files 27 28 +1
Lines 6788 6888 +100
Branches 1013 1044 +31
==========================================
+ Hits 6471 6565 +94
- Misses 193 195 +2
- Partials 124 128 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new free func import method!
Sample a curve based on a number of points or deflection. | ||
|
||
:param n: number of positions or deflection | ||
:return: A list of Vectors and a list of parameters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this supposed to be "returns" in this context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the docs :return:
https://sphinx-rtd-tutorial.readthedocs.io/en/latest/docstrings.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adam-urbanczyk !
Co-authored-by: Jeremy Wright <[email protected]>
sample
isoline
check
outputfunc
:from cadquery.func import *