Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header cleanup #1732

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Header cleanup #1732

merged 2 commits into from
Dec 27, 2024

Conversation

lorenzncode
Copy link
Member

No description provided.

@lorenzncode
Copy link
Member Author

@dcowden confirmed it's ok to change the file headers to something like this:

# Copyright (c) CadQuery Development Team.
# Distributed under the terms of the Apache 2 License

Given this, I proposed to eliminate the header info outside setup.py, LICENSE files (currently the outdated header does not appear in every file - only a few select files). There was agreement on this too. This PR retains a header in the main cq.py.

I see @adam-urbanczyk has fixed the mypy issue in another open PR.

@adam-urbanczyk adam-urbanczyk mentioned this pull request Dec 23, 2024
6 tasks
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.33%. Comparing base (6b3b14a) to head (074870d).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1732   +/-   ##
=======================================
  Coverage   95.32%   95.33%           
=======================================
  Files          27       28    +1     
  Lines        6788     6842   +54     
  Branches     1013     1025   +12     
=======================================
+ Hits         6471     6523   +52     
- Misses        193      194    +1     
- Partials      124      125    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-urbanczyk
Copy link
Member

LGTM, thanks @lorenzncode

@adam-urbanczyk adam-urbanczyk merged commit 29fbe38 into CadQuery:master Dec 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants