Add TypeVar to deprecate_kwarg_name to preserve type information #1733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue initially reported in #1308, based off changes in #1348.
Initially reported issue reported issues with functions typed with
deprecate_kwarg_name
, but the fix PR fixeddeprecate_kwarg
which appeared to suffer from the same issue. I'm encountering the initially reported issue with calls to.text
still, so this PR applies the fix from the initial issue description to thedeprecate_kwarg_name
class as well.I've tested locally and confirmed this resolves typing issues on
.text
for me.