Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeVar to deprecate_kwarg_name to preserve type information #1733

Merged

Conversation

nint8835
Copy link
Contributor

Fixes issue initially reported in #1308, based off changes in #1348.

Initially reported issue reported issues with functions typed with deprecate_kwarg_name, but the fix PR fixed deprecate_kwarg which appeared to suffer from the same issue. I'm encountering the initially reported issue with calls to .text still, so this PR applies the fix from the initial issue description to the deprecate_kwarg_name class as well.

I've tested locally and confirmed this resolves typing issues on .text for me.

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.33%. Comparing base (6b3b14a) to head (59fb8bc).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1733   +/-   ##
=======================================
  Coverage   95.32%   95.33%           
=======================================
  Files          27       28    +1     
  Lines        6788     6842   +54     
  Branches     1013     1025   +12     
=======================================
+ Hits         6471     6523   +52     
- Misses        193      194    +1     
- Partials      124      125    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-urbanczyk
Copy link
Member

Simple change, merging. Thanks @nint8835 !

@adam-urbanczyk adam-urbanczyk merged commit 0ebfa2b into CadQuery:master Dec 29, 2024
5 checks passed
@nint8835 nint8835 deleted the fix-deprecate_kwarg_name-typing branch December 29, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants