Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Edge.makeEllipse HTML docs #656

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

marcus7070
Copy link
Member

Currently HTML docs look like:
screenshot2021-02-24-172453

Just needed one blank line in the doc string.

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #656 (be24cc2) into master (e4ed881) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #656   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files          31       31           
  Lines        6636     6636           
  Branches      726      726           
=======================================
  Hits         6240     6240           
  Misses        258      258           
  Partials      138      138           
Impacted Files Coverage Δ
cadquery/occ_impl/shapes.py 91.89% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4ed881...be24cc2. Read the comment docs.

@marcus7070
Copy link
Member Author

That worked: https://cadquery--656.org.readthedocs.build/en/656/classreference.html#cadquery.Edge.makeEllipse

Trivial change, I'll just merge it.

@marcus7070 marcus7070 merged commit 2085054 into CadQuery:master Feb 24, 2021
@marcus7070 marcus7070 deleted the fixEllipseDocs branch February 24, 2021 07:28
@jmwright
Copy link
Member

@marcus7070 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants