-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start building CQ for py3.9 #672
Conversation
Codecov Report
@@ Coverage Diff @@
## master #672 +/- ##
==========================================
+ Coverage 94.03% 94.77% +0.74%
==========================================
Files 31 31
Lines 6642 9079 +2437
Branches 726 1132 +406
==========================================
+ Hits 6246 8605 +2359
- Misses 258 295 +37
- Partials 138 179 +41
Continue to review full report at Codecov.
|
We might also want to stop providing 3.6 builds |
@adam-urbanczyk What's the reasoning behind dropping support for Python 3.6? |
PEP 563 and shorter build times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adam-urbanczyk The comment I made is just a suggestion. This PR looks good.
azure-pipelines.yml
Outdated
- template: conda-build.yml@templates | ||
parameters: | ||
name: Linux_39 | ||
vmImage: 'ubuntu-16.04' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
16.04 is going EOL next month. GitHub Actions is going to start defaulting to 20.04 for the "latest" image when this EOL is hit. It might be worth moving to 18.04 for these builds while you're at it.
OK, merging. |
No description provided.