-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docstring and error message fixes #695
Conversation
fedorkotov
commented
Mar 17, 2021
- Fixed code examples in AreaNthSelector docstring (previously were not formatted as code blocks).
- Fixed some typos caught with Code Spell Checker VS Code extension
Codecov Report
@@ Coverage Diff @@
## master #695 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 31 31
Lines 6909 6909
Branches 740 740
=======================================
Hits 6523 6523
Misses 252 252
Partials 134 134
Continue to review full report at Codecov.
|
Here is the error from appveyor python 3.6 build (python 3.7 was syccessfull). This is probably not caused by my docstring and comment changes.. I think I'll have to wait until #696 is merged and rebase on that.
|
One of these days I will learn to not trust spellcheckers blindly ) |
Thanks @fedorkotov ! We were going to remove Python 3.6 from the CI matrix anyway, so that has been done and all the tests pass now. @marcus7070 @adam-urbanczyk These are straight forward doc fixes, so I'll go ahead and merge without the normal review process. |
1 similar comment
Thanks @fedorkotov ! We were going to remove Python 3.6 from the CI matrix anyway, so that has been done and all the tests pass now. @marcus7070 @adam-urbanczyk These are straight forward doc fixes, so I'll go ahead and merge without the normal review process. |