Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use expression grammar for assy selectors #704

Merged
merged 5 commits into from
Mar 29, 2021
Merged

Conversation

adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Mar 27, 2021

Will resolve #703

@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #704 (179b964) into master (6d3c9e5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #704   +/-   ##
=======================================
  Coverage   94.42%   94.42%           
=======================================
  Files          31       31           
  Lines        6909     6911    +2     
  Branches      740      740           
=======================================
+ Hits         6524     6526    +2     
  Misses        251      251           
  Partials      134      134           
Impacted Files Coverage Δ
cadquery/assembly.py 90.54% <100.00%> (ø)
tests/test_assembly.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d3c9e5...179b964. Read the comment docs.

tests/test_assembly.py Outdated Show resolved Hide resolved
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmwright jmwright merged commit df550f0 into master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assembly string selectors don't handle and
3 participants