-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raise TypeError when Location param is a tuple #723
Conversation
(copying my comment from now closed #722) |
Good point @fedorkotov. I have just choose to end with |
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
==========================================
- Coverage 94.51% 94.50% -0.02%
==========================================
Files 32 32
Lines 7078 7210 +132
Branches 768 786 +18
==========================================
+ Hits 6690 6814 +124
- Misses 254 261 +7
- Partials 134 135 +1
Continue to review full report at Codecov.
|
bb2e41d
to
d5cb4c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @RubenRubens!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RubenRubens !
Let me know if this was what you had on mind @marcus7070.
PR requested on #717 .