Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Comment on Documentation #727

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Minor Comment on Documentation #727

merged 1 commit into from
Apr 21, 2021

Conversation

andreubernadserra
Copy link

Expected cutout in make_panel function for "Initial assembly". Gathered from "Final Result".

@andreubernadserra andreubernadserra marked this pull request as ready for review April 16, 2021 08:41
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #727 (5dc7719) into master (b9167e3) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 5dc7719 differs from pull request most recent head ff490d9. Consider uploading reports for the commit ff490d9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
- Coverage   94.56%   94.55%   -0.02%     
==========================================
  Files          32       32              
  Lines        7218     7218              
  Branches      786      786              
==========================================
- Hits         6826     6825       -1     
- Misses        257      258       +1     
  Partials      135      135              
Impacted Files Coverage Δ
tests/test_workplanes.py 99.30% <0.00%> (-0.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9167e3...ff490d9. Read the comment docs.

@jmwright jmwright requested review from adam-urbanczyk and jmwright and removed request for adam-urbanczyk April 16, 2021 09:45
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RubenRubens I see now that SLOT_D was specified in one of the individual steps, but was not included in the final result. Without that the example gave an error.

@jmwright jmwright merged commit 25c3009 into CadQuery:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants