-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle constraints from infinite faces #797
Conversation
Codecov Report
@@ Coverage Diff @@
## master #797 +/- ##
==========================================
+ Coverage 95.17% 95.21% +0.04%
==========================================
Files 32 32
Lines 7436 7489 +53
Branches 797 798 +1
==========================================
+ Hits 7077 7131 +54
Misses 221 221
+ Partials 138 137 -1
Continue to review full report at Codecov.
|
I should mention, as an alternative to this we could just put a warning in the |
Is the docs build hung? |
Just GitHub not updating, the docs build is done: https://readthedocs.org/projects/cadquery/builds/14095186/ |
Interesting, I haven't seen that glitch before. |
Hm, same result on a rerun. |
At the bottom of the logs it says this without ever appending
Could that be related to the search box now working? |
caf83f1
to
cb1dfcc
Compare
I've rebased to include #801, incase that fixes RTD build. |
Looks like it did fix it. |
Actually, if/when #806 goes through I'll have to rewrite these tests. We might as well wait for that before merging this. |
cf29ea1
to
a489a44
Compare
Infinite faces have their center at 1e99, which was causing overflows in the solver and also was not what the user intended when creating the Shape. They are now converted to the expected values.
a489a44
to
4a03d7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marcus7070 !
Thanks @marcus7070 , shall I merge? |
Will close #758, where I wanted to specify a plane for a constraint (defined by an origin and a normal), so the obvious Shape to use was from
Face.makePlane(width=None, length=None)
, but this shape has a center at 1e99.To handle it I had to use
gp_Pln
a lot because it turns out two offset infinite faces will still have the same Center:But now by converting them to
gp_Pln
you can get the origin that the user intends: