Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTK.js camera default position #822

Merged
merged 5 commits into from
Jul 15, 2021
Merged

VTK.js camera default position #822

merged 5 commits into from
Jul 15, 2021

Conversation

marcus7070
Copy link
Member

@marcus7070 marcus7070 commented Jul 11, 2021

Here is the default isometric view from CQ-editor:
screenshot2021-07-11-160947

Here is the current doc's view:
screenshot2021-07-11-161351

Here is this PR's view:
screenshot2021-07-11-161436

@codecov
Copy link

codecov bot commented Jul 11, 2021

Codecov Report

Merging #822 (8c30e3b) into master (6a440b6) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 8c30e3b differs from pull request most recent head df722a8. Consider uploading reports for the commit df722a8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #822      +/-   ##
==========================================
- Coverage   95.21%   95.15%   -0.07%     
==========================================
  Files          32       32              
  Lines        7489     7489              
  Branches      798      798              
==========================================
- Hits         7131     7126       -5     
- Misses        221      224       +3     
- Partials      137      139       +2     
Impacted Files Coverage Δ
cadquery/cqgi.py 79.09% <0.00%> (-2.46%) ⬇️
tests/test_workplanes.py 100.00% <0.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a440b6...df722a8. Read the comment docs.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @marcus7070

cadquery/cq_directive.py Outdated Show resolved Hide resolved
Copy link
Member

@adam-urbanczyk adam-urbanczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think now it is roughly aligned with the default CQ-editor view

cadquery/cq_directive.py Outdated Show resolved Hide resolved
@marcus7070 marcus7070 merged commit ab876ac into master Jul 15, 2021
@marcus7070 marcus7070 deleted the marcus7070/vtkjs-cam-pos branch July 15, 2021 23:08
@adam-urbanczyk
Copy link
Member

Thanks @marcus7070 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants