Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixin3D.shell: removed deprecated OCCT method #829

Merged
merged 2 commits into from
Jul 29, 2021

Conversation

marcus7070
Copy link
Member

Will close #649.

I also shortened the code a bit, there was a few duplicated calls.

@marcus7070 marcus7070 marked this pull request as ready for review July 18, 2021 07:48
@codecov
Copy link

codecov bot commented Jul 18, 2021

Codecov Report

Merging #829 (3192df9) into master (ab876ac) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 3192df9 differs from pull request most recent head e41b030. Consider uploading reports for the commit e41b030 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #829   +/-   ##
=======================================
  Coverage   95.15%   95.15%           
=======================================
  Files          32       32           
  Lines        7489     7495    +6     
  Branches      798      799    +1     
=======================================
+ Hits         7126     7132    +6     
  Misses        224      224           
  Partials      139      139           
Impacted Files Coverage Δ
cadquery/cq.py 91.42% <ø> (ø)
cadquery/occ_impl/shapes.py 92.47% <100.00%> (+<0.01%) ⬆️
tests/test_cadquery.py 99.20% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab876ac...e41b030. Read the comment docs.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had the one question. Other than that it looks good. Thanks @marcus7070

@marcus7070 marcus7070 marked this pull request as draft July 23, 2021 05:27
@marcus7070 marcus7070 marked this pull request as ready for review July 23, 2021 06:23
@marcus7070 marcus7070 merged commit 7afbb37 into master Jul 29, 2021
@marcus7070 marcus7070 deleted the marcus7070/mixin3d-shell-update branch July 29, 2021 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated method used in Mixin3D.shell
3 participants