Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation wording #845

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Fix documentation wording #845

merged 1 commit into from
Aug 19, 2021

Conversation

revolter
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 15, 2021

Codecov Report

Merging #845 (4113ad8) into master (93623fa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #845   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files          32       32           
  Lines        7594     7594           
  Branches      806      806           
=======================================
  Hits         7282     7282           
  Misses        184      184           
  Partials      128      128           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93623fa...4113ad8. Read the comment docs.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @revolter

@jmwright jmwright requested a review from marcus7070 August 17, 2021 17:10
@jmwright
Copy link
Member

@marcus7070 @adam-urbanczyk I'm trying to spread the load of reviewers here a bit. Let me know if you don't have time to review or if you want to review and weren't tagged.

@revolter
Copy link
Contributor Author

This was displayed as

You can learn more about selectors Selectors

and now is displayed as

See Selectors to learn more.

which is also consistent with other sections too.

@marcus7070 marcus7070 merged commit 7bcd80e into CadQuery:master Aug 19, 2021
@marcus7070
Copy link
Member

Thankyou @revolter! It's great to get this stuff cleaned up!

@revolter
Copy link
Contributor Author

And I love cleaning stuff up ❤️

@revolter revolter deleted the patch-3 branch August 19, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants