Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect ParallelDirSelector documentation #848

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

revolter
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #848 (8dc4972) into master (93623fa) will not change coverage.
The diff coverage is n/a.

❗ Current head 8dc4972 differs from pull request most recent head c0efdc0. Consider uploading reports for the commit c0efdc0 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #848   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files          32       32           
  Lines        7594     7594           
  Branches      806      806           
=======================================
  Hits         7282     7282           
  Misses        184      184           
  Partials      128      128           
Impacted Files Coverage Δ
cadquery/selectors.py 98.14% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93623fa...c0efdc0. Read the comment docs.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @revolter

This is straight-forward, so I'm going to go ahead and merge this one once I figure out why the Windows/Python 3.7 check is failing.

@revolter
Copy link
Contributor Author

I'm pretty sure it's not related to my changes, but I couldn't restart the job myself.

@jmwright
Copy link
Member

@revolter There are weird glitches with builds in the CI system sometimes. It looks like it passed this time. Thanks for the contribution.

@jmwright jmwright merged commit 7b5dc6b into CadQuery:master Aug 17, 2021
@revolter revolter deleted the patch-5 branch August 17, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants