-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc/assy: add constraints #850
Conversation
It could be nice to have a note that says something like :
(I am not 100% sure this is true though lol) |
Thanks @Jojain. Yeah, I won't word it exactly like that (I think no initial locations is fine for the majority of uses), but if I'm explaining how constraints work then I should also explain initial locations as well. |
@marcus7070 Still seeing the following black error in CI.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @marcus7070 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, looks good! Just one more black run and all should be green.
Thanks, I just had to add a comma to a list. Assuming this all passes I'll merge in a few minutes. |
Just a leftover error because this branch doesn't contain #872, so I'll merge. |
Will resolve #715.
This is still a WIP, but it's mostly done and I won't be able to get back to it for a few days, so I figured I'd open this draft PR incase anyone wants to check it out.
Still to do:
Introduce dummy geometryIntroduce dummy Shapes in the assembly docs #856Explain why rotation has to be locked with PointInPlane, but you can get away without doing it for just PointNot going to add this, it reads better without itgen_colors.py
, it's not obvious what it's used for