Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests/test.brep to .gitignore. #865

Merged
merged 2 commits into from
Sep 2, 2021

Conversation

martinbudden
Copy link
Contributor

No description provided.

@jmwright
Copy link
Member

@martinbudden I'm guessing you ran the tests from within the tests directory, correct? I get the same artifact file in the root directory of the repo because that's normally where I run the tests from. I also have to clean out other test artifacts as well. Below is the list.

assy.wrl
assy.xml
assy.zip
nested.step
simple.caf
simple.step
simple.stp
simple.xml
test.brep

I think we'd be better off excluding the artifact files by name without the directory prefix so that no matter where the dev runs the tests from, they'll always be excluded properly.

@martinbudden
Copy link
Contributor Author

OK, I'll amend the PR to do that.

@martinbudden
Copy link
Contributor Author

OK, done.

@jmwright
Copy link
Member

jmwright commented Sep 1, 2021

@martinbudden What is the .~* entry for?

@martinbudden
Copy link
Contributor Author

The .~* is for locked files. In particular if you view the file file.dxf file in LibreOffice it creates a lock file .~lock.file.dxf#. So this prevents those locked files appearing in your difference list.

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #865 (c94445a) into master (0b2a075) will not change coverage.
The diff coverage is n/a.

❗ Current head c94445a differs from pull request most recent head d8ba84e. Consider uploading reports for the commit d8ba84e to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #865   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files          32       32           
  Lines        7654     7654           
  Branches      815      815           
=======================================
  Hits         7339     7339           
  Misses        186      186           
  Partials      129      129           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b2a075...d8ba84e. Read the comment docs.

@jmwright
Copy link
Member

jmwright commented Sep 2, 2021

Ok, looks good. Thanks @martinbudden

@jmwright jmwright merged commit 94030ad into CadQuery:master Sep 2, 2021
@martinbudden martinbudden deleted the gitignore_tests branch September 2, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants