Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use vtkmodules import instead of vtk #918

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

darrellenns
Copy link
Contributor

fixes #915

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #918 (1e6e20b) into master (930ceb9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #918   +/-   ##
=======================================
  Coverage   95.94%   95.94%           
=======================================
  Files          32       32           
  Lines        7825     7827    +2     
  Branches      846      846           
=======================================
+ Hits         7508     7510    +2     
  Misses        184      184           
  Partials      133      133           
Impacted Files Coverage Δ
cadquery/occ_impl/assembly.py 96.03% <100.00%> (ø)
cadquery/occ_impl/exporters/assembly.py 100.00% <100.00%> (ø)
cadquery/occ_impl/exporters/vtk.py 100.00% <100.00%> (ø)
cadquery/occ_impl/shapes.py 92.70% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 930ceb9...1e6e20b. Read the comment docs.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @darrellenns

@adam-urbanczyk adam-urbanczyk merged commit 3581904 into CadQuery:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vtk - import requires unnecessary dependencies
3 participants