Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add __repr__ to plane #952

Merged
merged 5 commits into from
Jan 9, 2022
Merged

Conversation

Jojain
Copy link
Contributor

@Jojain Jojain commented Jan 6, 2022

Resolve #739, didn't added test it as it is really trivial

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #952 (3e0d85e) into master (6c8502f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #952   +/-   ##
=======================================
  Coverage   96.07%   96.08%           
=======================================
  Files          39       39           
  Lines        9233     9238    +5     
  Branches     1111     1111           
=======================================
+ Hits         8871     8876    +5     
  Misses        209      209           
  Partials      153      153           
Impacted Files Coverage Δ
cadquery/occ_impl/geom.py 99.58% <100.00%> (+<0.01%) ⬆️
tests/test_cadquery.py 99.27% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c8502f...3e0d85e. Read the comment docs.

Jojain added 2 commits January 7, 2022 15:28
added test because CI was complaining
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @Jojain

@adam-urbanczyk
Copy link
Member

LGTM, thanks @Jojain !

@adam-urbanczyk adam-urbanczyk merged commit ea66ded into CadQuery:master Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better __repr__ on Plane
3 participants