Additional constraints

[adam-urbanczyk]

• simplification of the assy solver
• validation
• PointOnLine
• FixedPoint
• FixedAxis
• FixedRotation
• docs

[adam-urbanczyk]

I did not add the new constraints yet, but @marcus7070 @lorenzncode could you take a look to see if the reworked version is more readable?

[codecov]

Codecov Report

Merging #975 (6fda0b8) into master (ed8e62c) will increase coverage by 0.08%.
The diff coverage is 96.39%.

❗ Current head 6fda0b8 differs from pull request most recent head 723ed4f. Consider uploading reports for the commit 723ed4f to get more accurate results

@@            Coverage Diff             @@
##           master     #975      +/-   ##
==========================================
+ Coverage   96.17%   96.26%   +0.08%     
==========================================
  Files          40       40              
  Lines        9292     9341      +49     
  Branches     1109     1103       -6     
==========================================
+ Hits         8937     8992      +55     
+ Misses        208      205       -3     
+ Partials      147      144       -3     

Impacted Files	Coverage Δ
cadquery/occ_impl/solver.py	95.88% <94.49%> (+1.59%)	⬆️
cadquery/assembly.py	95.00% <97.36%> (+1.53%)	⬆️
tests/test_assembly.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed8e62c...723ed4f. Read the comment docs.

[marcus7070]

This looks fantastic @adam-urbanczyk, thanks so much for doing it!

[adam-urbanczyk]

Ok, I think that this is it @jmwright @lorenzncode @marcus7070 . The only thin I don't really like is the automatic fixed constraint handling. Maybe in the future (not in this PR) we should require an explicit Fixed constraint being specified.

[lorenzncode]

I've added a few minor suggestions for docs, error messages.

[jmwright]

Looks good, thanks for all the work @adam-urbanczyk

I'm relying on @marcus7070 and @lorenzncode quite a bit for this review since it seems that they understand the subtleties of the constraint system better than I do.

[adam-urbanczyk]

Great, I'll merge tomorrow.