-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change conda related sections in the README and the docs #980
Conversation
+initial work on FixedPoint
Co-authored-by: Marcus Boyd <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #980 +/- ##
=======================================
Coverage 96.26% 96.26%
=======================================
Files 40 40
Lines 9342 9344 +2
Branches 1103 1104 +1
=======================================
+ Hits 8993 8995 +2
Misses 205 205
Partials 144 144
Continue to review full report at Codecov.
|
@adam-urbanczyk This PR looks good to me except that I haven't used miniforge, so I don't know it's strengths/weaknesses vs miniconda. |
@jmwright miniforge is a minimal conda installation configured to use the (free) conda-forge channel (which is the channel we are relying on). I also added this based on the comments on bloat floating around HaD/HN. I also added section on portable win install. |
Ok, thanks @adam-urbanczyk . @Jojain since you're already involved in this discussion, will you be the other official reviewer? We normally try to have two devs check a PR before merging unless it's a super simple one. |
Sure if you want too, I will try this new installation process |
@Jojain If you have time, please do. |
@adam-urbanczyk Then |
It installs fine for me in Ubuntu, so maybe the problem is specific to Windows? |
The installation of miniforge works on a Lubuntu 20.04 VM, but the environment solve always fails when I try to run the following line.
|
I made a stupid copy-paster error - should be corrected now @Jojain . |
I got the install successful. I've read very quickly what is miniforge, if I understand well (put aside what's under the hood) miniforge is miniconda with the default channel setup to Since I have also miniconda installed I don't know which one is activating but if I run |
@Jojain On Linux, I run something like |
Can you share (link to) the vm image? |
VM image download is here. I ran it in VirtualBox. |
@jmwright This could be an out of memory issue. I've also experienced that with One advantage of miniforge is it also provides mamba. You might try replacing I checked RSS of the conda/mamba install process today on Ubuntu 20.04. |
I don't really want to break my miniconda install to try miniforge alone, but I have been successful with the installation and activate on my Windows computer, so I think it's good (I've also read it's bundled directly with mamba ?) |
If |
I don't know about the memory but it's faster than conda and gives better error message when there is dependencies conflicts (however for some reason |
I have just nuked miniconda install on Windows and replaced it with mambaforge (condaforge variant with mamba preinstalled in base environment). It is fast. And |
…uery into conda-instructions
I just switched to mambaforge and it worked fine to create a CadQuery environment, and |
I am also unable to reproduce #990 on Windows 11 64-bit with mambaforge. I'm ok with using mambaforge, but again, don't have a lot of experience with it. I have switch my systems over to it and will be using it as my primary way to handle my CadQuery environments moving forward. |
OK, so I'd propose to stay with conda for now. The only known issue is the memory usage, I think that it is acceptable. |
For me a workaround for #990 on Windows 8.1 was adding |
Alright merging with conda/miniforge, in the future we'll probably change it to mamba/mambaforge. |
Small improvements of the conda installation instructions.