Exclude geometry lights from propid #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caeden117
added a commit
that referenced
this pull request
Jul 27, 2024
* Render console above loading screen * Fix incorrect setting bind for ShowNonImportantErrors * Actually reduce spectrogram quality if > half VRAM * Add more keybinds for changing UIMode * Account for vram spike in quality check * Update customData on placement Used in conflicting object check * Consolidate edit bookmark name and colour uis into single edit * we'd like to save the name if the text *isnt* null * Add failing grouped lightID test * Fix events not mirroring in grouped lightID * More event mirror lightID test cases * Fix dragged note cut direction appearance not updating * Only refresh pool on preview mode change * Remove bpm tapper blocking UIMode switch * Distinguish Reverse from other UIMode actions The brackets indicate it functions like the others so removing it * Remove now unused bookmark color keybind * Fix edit bookmark initial value * Fix nested color picker submit not updating correctly * Fix playback stopping on bookmark click * Fix the open config folder button on Linux (#534) * Fix the open config folder button on Linux * Helper function for OS file browser * Fix transition easing ordering * Yeet commented out code * Adjust transition generator for new logic * Add rotation event test * Fix 360 placement being unusable after last event * Exclude rotation event callback at same time * Exclude geometry lights from propid (#537) * Add bookmark brightness option * Bookmarks now darken on hover * Allow creating bookmarks with alpha (will still default to 1 if the user does not change it) * Crowdin translation update * Fix potentially sending outdated map to peers * Wait for map to save before exiting to song info * Fix bpm events not being converted * Build ChroMapper in Release mode --------- Co-authored-by: Bullet <[email protected]> Co-authored-by: kobting <[email protected]> Co-authored-by: Fallen Charlotte <[email protected]>
Caeden117
pushed a commit
that referenced
this pull request
Aug 2, 2024
Caeden117
pushed a commit
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where all geometry-added light ids are grouped under propid 1
Example:
