Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #66

Merged
merged 4 commits into from
Feb 18, 2022
Merged

Fix tests #66

merged 4 commits into from
Feb 18, 2022

Conversation

arodu
Copy link
Member

@arodu arodu commented Jan 22, 2022

  • fix some tests
  • add CI tests for php 8.1

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2022

Codecov Report

Merging #66 (c0e9fac) into 6.next-cake4 (803bbe9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##             6.next-cake4      #66   +/-   ##
===============================================
  Coverage           90.37%   90.37%           
  Complexity            323      323           
===============================================
  Files                  46       46           
  Lines                 800      800           
===============================================
  Hits                  723      723           
  Misses                 77       77           
Impacted Files Coverage Δ
src/Authentication/AuthenticationService.php 98.11% <ø> (ø)
...on/DefaultOneTimePasswordAuthenticationChecker.php 100.00% <ø> (ø)
...Authentication/DefaultU2fAuthenticationChecker.php 100.00% <ø> (ø)
...ication/DefaultWebauthn2fAuthenticationChecker.php 100.00% <ø> (ø)
src/Rbac/Rbac.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 803bbe9...c0e9fac. Read the comment docs.

Copy link
Member

@steinkel steinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix coding standard issues reported

@steinkel steinkel merged commit b593407 into CakeDC:6.next-cake4 Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants