Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CakePHP 5 upgrade #76

Merged
merged 1 commit into from
Jan 18, 2023
Merged

CakePHP 5 upgrade #76

merged 1 commit into from
Jan 18, 2023

Conversation

LordSimal
Copy link
Contributor

Basically the same as #75 just with the new branch

@rochamarcelo rochamarcelo requested a review from steinkel January 10, 2023 21:49
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 85.50725% with 20 lines in your changes missing coverage. Please review.

Project coverage is 90.51%. Comparing base (716617e) to head (c1acf25).
Report is 26 commits behind head on 8.next-cake5.

Files with missing lines Patch % Lines
src/Test/BaseTestTrait.php 0.00% 5 Missing ⚠️
src/Traits/ReCaptchaTrait.php 20.00% 4 Missing ⚠️
src/Social/Service/OAuth1Service.php 40.00% 3 Missing ⚠️
src/Social/Service/OAuth2Service.php 50.00% 3 Missing ⚠️
src/Authentication/AuthenticationService.php 91.66% 1 Missing ⚠️
src/Rbac/Permissions/AbstractProvider.php 80.00% 1 Missing ⚠️
src/Rbac/Rules/RuleRegistry.php 50.00% 1 Missing ⚠️
src/Social/Mapper/Amazon.php 0.00% 1 Missing ⚠️
src/Social/Mapper/Tumblr.php 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                 @@
##             8.next-cake5      #76      +/-   ##
==================================================
+ Coverage           90.39%   90.51%   +0.12%     
- Complexity            317      319       +2     
==================================================
  Files                  46       46              
  Lines                 781      886     +105     
==================================================
+ Hits                  706      802      +96     
- Misses                 75       84       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skie skie merged commit a4fcee8 into CakeDC:8.next-cake5 Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants