Fix to off-by-one for TopK and related test cases #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After playing with the TopK example, I realized the output was not as expected. After looking into this, it's because the iteration used to pull the items out of the heap was using an improper lower bound index of greater than zero. The test cases passed because they only evaluated in comparison to the expected values by order of those returned by TopK instead of using the expected as the baseline, which meant the missing value was not found in the test cases. Accordingly, I updated the test cases to include the actual vs. expected length of the
.values()
and.iterator()
. Likewise, iterator was being used in the first values test case, which was also incorrect.