Add support for count parameter in TopK add method. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1. I also need this feature. Thank you jonahharris |
|
Hi, sorry for the response delay on this PR. Thanks for the addition, it's a neat idea! I'm merging it right away ;) |
|
Thank you, @Callidon. This has been a really useful library. Thanks for writing and sharing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently working on a project with semi-aggregated source data, which requires me to pass the precomputed frequency to the Top-K algorithm directly, rather than strictly on a one-at-a-time per-call-oriented basis. As TopK doesn't implement the CountingFilter interface, which I could see arguments for and against given its underlying algorithm is count-min-sketch, I avoided refactoring that and added a
countparameter to its add method with a default value of one, similar toCountingFilter.update. Test case added accordingly. Thoughts?