Fix import of inner count min for TopK import #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thanks for creating this library! It's been very helpful.
I'm currently working with the TopK data structure and encountered a bug.
It seems that it's throwing this error whenever I am trying to update an imported TopK.
This is the code for the bug replication
https://stackblitz.com/edit/node-kcv3z7?file=index.js
I figured that this might be due to the inner count-min sketch not being properly initialized during import.
I am not that confident that I understand what the decorators do, but based on how the inner heap is imported I made the following fix in the TopK class.
I also made the corresponding tests for this. I hope this fixes the bug.