Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

road to 2.0.0 #52

Merged
merged 57 commits into from
Feb 18, 2022
Merged

road to 2.0.0 #52

merged 57 commits into from
Feb 18, 2022

Conversation

folkvir
Copy link
Collaborator

@folkvir folkvir commented Feb 13, 2022

NEW:

  • Add XorFilter #29
  • Add #PR44 optimizing the BloomFilter internal storage with Uint arrays.
  • Add .nextInt32() function to get a new random seeded int 32-bits from the current seed.
  • Move all hashing related functions to its specific Hash class in a component of the BaseFilter class. It also allows for overriding the serizalize function for using custom hash functions

FIX:

  • Use correctly double hashing #issue43.
  • Disable 10.x and 15.x node tests.
  • Make all properties public for allowing developpers to override everything.

folkvir and others added 30 commits November 30, 2021 15:19
@folkvir
update deps and add gts
8a940e1
@folkvir
h64 only + fix #43 + gts
e15643c
mocha: parallel execution
210a3d1
utils: rename *Indices to *Indexes, add better documentation
801ad33
tests: show difference when using getDistinctIndexes w/wo hashing at …
fbc47a3 
…each iteration
utils: rename *Indices to *Indexes
6e9cbcd
update ref pdf of CMS
6124392
@folkvir
double hashing: use the enhanced technique
b3d6493
@folkvir
getDistinctIndexes: implement #43 suggestions + allow to switch to XX…
1662d80 
…H 32/64 if needed
@folkvir
update changelog
99de688
@folkvir
add .DS_Store in the list of ignored files
4fa3908
@folkvir
use typescript 4.X.X
2336f27
@folkvir
fix typo of #46
2d58a81
@folkvir
fix error when setting 32/64 bits xxh functions, and allow for overri…
9358c94 
…ding the serialize function (#48)
@folkvir
add code coverage
83a74a9
@folkvir
lint
4eb5dab
@folkvir
update eslint ignore for faster parsing
5a5ce5b
@folkvir
add branch update_outdated to the tested branches
9a76c81
@folkvir
fix wrong github workflow branch name
f98fe85
@folkvir
workflow: use 16.x and remove 10.x
a6790cd
@folkvir
update README and remove useless deps
40c97db
@folkvir
tests: fix error with describe/it rules overriding data
dfa01af
@folkvir
implemnting xor filter for the next release
cd57224
@folkvir
Merge pr44 into develop
ad94f7b
@folkvir
update all files to the new project standard, set v2.0.0
a174147
@folkvir
xor filters are working
e2cf703
@folkvir
testing the xor filter
6ad96c9
@folkvir
xor filter #29
3d4d57e
@folkvir
#29
ed02f08
@folkvir
documentation
2b9eed1
folkvir added 19 commits January 3, 2022 14:10
@folkvir
modify tests according to: 12417e7
0629797
@folkvir
parallel mocha tests
37b3903
@folkvir
use lts/* with setup-node@v2
bc3d574
@folkvir
update README.md
cc78acb
@folkvir
add badge to the readme
11b7877
@folkvir
export BaseFilter in the entry
04b35dc
@folkvir
badge refers to the last action build
ab96120
@folkvir
update compatibility readme
d4b3f38
@folkvir
update @types/node version to be the latest minor release
f8cc978
@folkvir
prettier auto line endings
63ea5c4
@folkvir
update @types/node version to be the latest minor release
062d889
@folkvir
#49 add compatibility with 1.3.4
c2e9f51
@folkvir
#49 compatibility for BloomFilters import only is working
975e4ba
@folkvir
Use AutoExportable feature for simplfying the export process, bitsets…
ee8d208 
… size set to a multiple of bitwords
@folkvir
create Hashing classes
8aef51e
@folkvir
remove nyc, use eslint + prettier instead of gts, enforce type checki…
b268c97 
…ng, make all propeties public, no readonly
@folkvir
update yarn.lock
c0a1ee8
@folkvir
ci: remove node 15
57b6906
@folkvir
fix missing dependency and fix eslint errors
9defecd
@folkvir folkvir requested a review from Callidon February 13, 2022 14:40
@folkvir
Copy link
Collaborator Author

folkvir commented Feb 13, 2022

This will need a serious squash commit before merging !!

@Callidon
Copy link
Owner

FYI I will look at this on Thursday morning 😉

Callidon
Callidon approved these changes Feb 18, 2022
View reviewed changes
Copy link
Owner

@Callidon Callidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats, great work 👍 🙏
Juste a small question but it's juste for my personal knowledge.
I'm merging the PR with a squash and will do the npm release right after 🚀

.github/workflows/npm_test_doc.yml
@@ -24,8 +26,8 @@ jobs:
key: ${{ runner.os }}-${{ matrix.node-version }}-${{ hashFiles('yarn.lock') }}
- name: Install package
if: steps.cache.outputs.cache-hit != 'true'
run: yarn install
run: npm install -g yarn && yarn install
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn is supposed to be installed by actions/setup-node, it is not true anymore?

@Callidon Callidon merged commit f580c3c into master Feb 18, 2022
@Callidon Callidon deleted the develop branch February 18, 2022 09:34
@Callidon Callidon mentioned this pull request Feb 18, 2022
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Callidon Callidon Callidon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@folkvir @Callidon