Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using sys.executable when building wheels #161

Merged
merged 1 commit into from
May 9, 2022
Merged

Stop using sys.executable when building wheels #161

merged 1 commit into from
May 9, 2022

Conversation

RibomBalt
Copy link
Contributor

Handle issue #160 .

I didn't realize sys.executable cannot be used if wheels were built on a different computer. In this patch, the argv is sys.executable only when directly installing from source, and remains python when building wheels.

blink1073
blink1073 approved these changes May 8, 2022
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll make a release with this on Monday

@blink1073 blink1073 added the bug label May 9, 2022
@blink1073 blink1073 merged commit 96533ae into Calysto:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RibomBalt @blink1073